Skip to content

Commit

Permalink
Add link to work log issue in FIX_LOWERING_FOR_CORE_ATEN_OPS.md (pyto…
Browse files Browse the repository at this point in the history
…rch#5944)

Add link to pytorch#5934 in our FIX_LOWERING_FOR_CORE_ATEN_OPS.md.
  • Loading branch information
wonjoolee95 authored and ManfeiBai committed Dec 1, 2023
1 parent 24d108f commit d929d8c
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions FIX_LOWERING_FOR_CORE_ATEN_OPS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
In order for PyTorch/XLA to support the PyTorch core ATen opset, it requires lowering each core ATen op in PyTorch/XLA. Note that this document will serve as a guide for fixing these lowering for core aten opset, specifically looking at [test_core_aten_ops.py test](https://github.com/pytorch/xla/blob/master/test/test_core_aten_ops.py). This guide will **not** cover how to lower an op in PyTorch/XLA, please refer our [op lowering guide](https://github.com/pytorch/xla/blob/master/OP_LOWERING_GUIDE.md) for this.

We also have a worklog for lowering these core aten ops in a GitHub issue, so we can track who's working on which ops and share some findings: [[Core Aten ops] Logs for fixing core aten ops coverage issues](https://github.com/pytorch/xla/issues/5934).

Let's go back and take a closer look at the [test_core_aten_ops.py test](https://github.com/pytorch/xla/blob/master/test/test_core_aten_ops.py), which is the source of truth to verify and correctness of these lowerings. The core of this test file is the `run_export_and_compare` at https://github.com/pytorch/xla/blob/master/test/test_core_aten_ops.py#L28. Each op unit test initializes the input and passes the op as a function and its inputs. The `run_export_and_compare` has multiple subtests that have the following structure:
- `torch_eval`
- `torch_xla_eval`
Expand Down

0 comments on commit d929d8c

Please sign in to comment.