Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CloudNetworks spec with empty including() #1267

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Fix CloudNetworks spec with empty including() #1267

merged 1 commit into from
Aug 30, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Aug 30, 2024 •
edited
Loading

This spec was unchanged since being introduced in fa4e0a6 but a bump to rspec-expectations 3.13.2 raised the issue that it wasn't actually testing anything.

@agrare agrare requested a review from bdunne as a code owner August 30, 2024 17:24
@jrafanie
Copy link
Member

@agrare should the tests be passing? 😕

@agrare
Copy link
Member Author

agrare commented Aug 30, 2024

should the tests be passing? 😕

No, this only fixes the cloud_networks spec not the resource_pool identifier issue.

@jrafanie
Copy link
Member

jrafanie commented Aug 30, 2024 •
edited
Loading

Merging. We have other 🔴 failures to be fixed outside of this PR.

@jrafanie jrafanie self-assigned this Aug 30, 2024
@jrafanie jrafanie merged commit 4e4e1a0 into ManageIQ:master Aug 30, 2024
2 of 4 checks passed
@jrafanie
Copy link
Member

Marked for radjabov/yes? since we can pull in rspec-expectations 3.13.2 on that branch too.

@agrare agrare deleted the fix_cloud_networks_a_collection_including branch August 30, 2024 19:58
@Fryguy
Copy link
Member

Fryguy commented Sep 4, 2024

Backported to radjabov in commit 3803fa5.

commit 3803fa5647a1401f42bf3e49622f1067a52ee1ee
Author: Joe Rafaniello <[email protected]>
Date:   Fri Aug 30 14:21:35 2024 -0400

    Merge pull request #1267 from agrare/fix_cloud_networks_a_collection_including
    
    Fix CloudNetworks spec with empty including()
    
    (cherry picked from commit 4e4e1a07c1f14575a11ad8eb09265331f96adba4)

Fryguy pushed a commit that referenced this pull request Sep 4, 2024
@jrafanie @Fryguy
Merge pull request #1267 from agrare/fix_cloud_networks_a_collection_…
3803fa5 
…including

Fix CloudNetworks spec with empty including()

(cherry picked from commit 4e4e1a0)
@Fryguy
Copy link
Member

Fryguy commented Oct 2, 2024

Backported to quinteros in commit c195eab.

commit c195eab46bc1e31301d49401ab8d29686fc4ef2c
Author: Joe Rafaniello <[email protected]>
Date:   Fri Aug 30 14:21:35 2024 -0400

    Merge pull request #1267 from agrare/fix_cloud_networks_a_collection_including
    
    Fix CloudNetworks spec with empty including()
    
    (cherry picked from commit 4e4e1a07c1f14575a11ad8eb09265331f96adba4)

Fryguy pushed a commit that referenced this pull request Oct 2, 2024
@jrafanie @Fryguy
Merge pull request #1267 from agrare/fix_cloud_networks_a_collection_…
c195eab 
…including

Fix CloudNetworks spec with empty including()

(cherry picked from commit 4e4e1a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryguy Fryguy Fryguy approved these changes

@bdunne bdunne Awaiting requested review from bdunne bdunne is a code owner

Assignees

@jrafanie jrafanie

Labels
bug quinteros/backported radjabov/backported test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @jrafanie @Fryguy