Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stub_supports/supports_not for VM Scan specs #1245

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

agrare
Copy link
Member

@agrare agrare commented Jan 5, 2024

Now that we have moved the smartstate_analysis supports feature into the provider VM subclasses we have to stub_supports/stub_supports_not in generic VM API tests.

Introduced by ManageIQ/manageiq#22738

Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thikn we should also add a case for "scan multiple Vms" but where at least one is not scannable.

Now that we have moved the smartstate_analysis supports feature into the
provider VM subclasses we have to stub_supports/stub_supports_not in
generic VM API tests.
@agrare agrare force-pushed the fix_vm_scan_support branch from 37ab2cc to 71f18ff Compare January 5, 2024 21:28
@miq-bot
Copy link
Member

miq-bot commented Jan 5, 2024

Checked commit agrare@71f18ff with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy Fryguy merged commit d909619 into ManageIQ:master Jan 5, 2024
3 checks passed
@Fryguy
Copy link
Member

Fryguy commented Jan 5, 2024

Backported to quinteros in commit 4684141.

commit 4684141df0b41c0b095dbd1d9e2ebc8e7a85b651
Author: Jason Frey <[email protected]>
Date:   Fri Jan 5 17:43:04 2024 -0500

    Merge pull request #1245 from agrare/fix_vm_scan_support
    
    Add stub_supports/supports_not for VM Scan specs
    
    (cherry picked from commit d90961901980af8d889dc3d97f93320b67cccb8e)

Fryguy added a commit that referenced this pull request Jan 5, 2024
Add stub_supports/supports_not for VM Scan specs

(cherry picked from commit d909619)
@agrare agrare deleted the fix_vm_scan_support branch January 6, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants