Drop legacy Host credentials payload, replaced by DDF params #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrare
force-pushed
the
drop_legacy_hosts_edit_verify
branch
from
b33208b to
3f9e2a8
Compare
agrare
commented
Dec 19, 2023
| creds.reverse_merge!(:userid => host.authentication_userid(auth_type)) | ||
| hash[auth_type.to_sym] = creds | ||
| if authentications.present? | ||
| authentications.deep_symbolize_keys! |
There was a problem hiding this comment.
NOTE update_authentications only works with symbolized keys
agrare
commented
Dec 19, 2023
| remember_host = data["remember_host"] == "true" | ||
| authentications, auth_type = symbolize_password_keys!(data[AUTH_ATTR]) | ||
| {:task_id => host.verify_credentials_task(User.current_userid, auth_type, :credentials => authentications, :remember_host => remember_host)} | ||
| auth_type = data["authentications"].keys.first |
There was a problem hiding this comment.
NOTE In the future I'd like to make Host#verify_credentials as close as possible to ExtManagementSystem#verify_credentials which takes just the data payload and no auth_type.
Fryguy
reviewed
Dec 19, 2023
Fryguy
reviewed
Dec 19, 2023
Fryguy
approved these changes
Dec 19, 2023
agrare
force-pushed
the
drop_legacy_hosts_edit_verify
branch
from
3f9e2a8 to
6edb2a3
Compare
|
Checked commit agrare@6edb2a3 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
agrare
changed the title
agrare
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a period of time we supported both the older
:credentialspayload as well as the newer DDFauthentications => {auth_type => {userid, password}}style.#1202
Now that the host edit form is in react (ManageIQ/manageiq-ui-classic#8608) we no longer need to keep this old style around.
Depends on:
Follow-up: