Testnet4 - 1.23

.cargo/config

@@ -4,11 +4,27 @@
 # configuration file. This is a similar workaround to the ones presented here:
 # <https://github.com/EmbarkStudios/rust-ecosystem/issues/59>
 xclippy = [
-    "clippy", "--all-targets", "--",
+    "clippy", "--all-targets", "--all-features", "--",
     "-Wclippy::all",
     "-Wclippy::disallowed_methods",
 ]
 xlint = "run --package x --bin x -- lint"
+xtest = "run --package x --bin x -- external-crates-tests"
+
+# Configuration specifically for running clippy on `external-crates/move/`.
+# Some of these allows are to avoid code churn; others are filed as issues on the `sui` repo now.
+move-clippy = [
+    "clippy", "--",
+    "-Wclippy::all",
+    "-Wclippy::disallowed_methods",
+    "-Aclippy::upper_case_acronyms",
+    "-Aclippy::type_complexity",
+    # Remove after https://github.com/rust-lang/rust-clippy/pull/11792 is released.
+    "-Aclippy::map_identity",
+    "-Aclippy::new_without_default",
+    "-Aclippy::box_default",
+    "-Aclippy::manual_slice_size_calculation",
+]
 
 [build]
 rustflags = ["-C", "force-frame-pointers=yes", "-C", "force-unwind-tables=yes"]

.changeset/config.json

@@ -1,17 +1,22 @@
 {
-  "$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
-  "changelog": "@changesets/cli/changelog",
-  "commit": false,
-  "fixed": [],
-  "linked": [],
-  "access": "public",
-  "baseBranch": "main",
-  "updateInternalDependencies": "minor",
-  "ignore": [
-    "sui-explorer",
-    "sui-wallet",
-    "demo-nft-dapp",
-    "sui-wallet-adapter",
-    "@mysten/core"
-  ]
+	"$schema": "https://unpkg.com/@changesets/[email protected]/schema.json",
+	"changelog": "@changesets/cli/changelog",
+	"commit": false,
+	"fixed": [],
+	"linked": [],
+	"access": "public",
+	"baseBranch": "main",
+	"updateInternalDependencies": "minor",
+	"privatePackages": false,
+	"ignore": [
+		"sui-wallet",
+		"@mysten/core",
+		"sponsored-transactions",
+		"kiosk-demo",
+		"kiosk-cli",
+		"@mysten/sdk-docs"
+	],
+	"___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
+		"onlyUpdatePeerDependentsWhenOutOfRange": true
+	}
 }

.changeset/slimy-suits-prove.md

@@ -0,0 +1,5 @@
+---
+'@mysten/enoki': patch
+---
+
+Add network to execution flow

.changeset/sweet-gorillas-remember.md

@@ -0,0 +1,5 @@
+---
+'@mysten/enoki': patch
+---
+
+Add missing network param to enokiflow

.clippy.toml

@@ -9,6 +9,8 @@ disallowed-methods = [
     { path = "tokio::sync::mpsc::unbounded_channel", reason = "use a bounded channel instead" },
     { path = "futures::channel::mpsc::unbounded", reason = "use a bounded channel instead" },
     { path = "futures_channel::mpsc::unbounded", reason = "use a bounded channel instead" },
+    # known to cause blocking issues
+    { path = "futures::executor::block_on", reason = "use tokio::runtime::runtime::Runtime::block_on instead"},
     # bincode::deserialize_from is easy to shoot your foot with
     { path = "bincode::deserialize_from", reason = "use bincode::deserialize instead" },
 ]

.config/nextest.toml

@@ -1,15 +1,38 @@
 [profile.ci]
+# Print output for failing tests only when they fail.
+failure-output = "immediate"
+# Show skipped tests in the CI output.
+status-level = "skip"
+# Do not cancel the test run on the first failure.
+fail-fast = false
+# Retry failing tests in order to not block builds on flaky tests
+retries = 5
+# Timeout tests after 10 minutes
+slow-timeout = { period = "60s", terminate-after = 10 }
+
+[profile.narwhalnightly]
 # Print out output for failing tests as soon as they fail, and also at the end
 # of the run (for easy scrollability).
 failure-output = "immediate-final"
 # Show skipped tests in the CI output.
 status-level = "skip"
 # Do not cancel the test run on the first failure.
 fail-fast = false
-# Retry failing tests in order to not block builds on flaky tests
-retries = 5
-# Timeout tests after 4 minutes
-slow-timeout = { period = "60s", terminate-after = 4 }
+# Do not retry failing tests
+retries = 0
+# Mark tests as slow after 7 hours, kill them right after
+slow-timeout = { period = "7h", terminate-after = 1 }
+
+[profile.simtestnightly]
+# Print out output for failing tests as soon as they fail, and also at the end
+# of the run (for easy scrollability).
+failure-output = "immediate"
+# Show skipped tests in the CI output.
+status-level = "fail"
+# Do not cancel the test run on the first failure.
+fail-fast = false
+# Mark tests as slow after 20m, terminate after 1h
+slow-timeout = { period = "20m", terminate-after = 3 }
 
 [profile.ci.junit]
 path = "junit.xml"

.dockerignore

@@ -6,3 +6,4 @@ target/
 *.md
 build/
 storage/
+docker/

.eslintrc.js

@@ -0,0 +1,164 @@
+// Copyright (c) Mysten Labs, Inc.
+// SPDX-License-Identifier: Apache-2.0
+
+module.exports = {
+	plugins: ['@tanstack/query', 'unused-imports', 'prettier', 'header', 'require-extensions'],
+	extends: [
+		'eslint:recommended',
+		'react-app',
+		'plugin:@tanstack/eslint-plugin-query/recommended',
+		'prettier',
+		'plugin:prettier/recommended',
+		'plugin:import/typescript',
+	],
+	settings: {
+		react: {
+			version: '18',
+		},
+		'import/resolver': {
+			typescript: true,
+		},
+	},
+	env: {
+		es2020: true,
+	},
+	root: true,
+	ignorePatterns: [
+		'node_modules',
+		'build',
+		'dist',
+		'coverage',
+		'apps/icons/src',
+		'next-env.d.ts',
+		'doc/book',
+		'external-crates',
+		'storybook-static',
+		'.next',
+	],
+	rules: {
+		'no-case-declarations': 'off',
+		'no-implicit-coercion': [2, { number: true, string: true, boolean: false }],
+		'@typescript-eslint/no-redeclare': 'off',
+		'@typescript-eslint/ban-types': [
+			'error',
+			{
+				types: {
+					Buffer: 'Buffer usage increases bundle size and is not consistently implemented on web.',
+				},
+				extendDefaults: true,
+			},
+		],
+		'no-restricted-globals': [
+			'error',
+			{
+				name: 'Buffer',
+				message: 'Buffer usage increases bundle size and is not consistently implemented on web.',
+			},
+		],
+		'header/header': [
+			2,
+			'line',
+			[' Copyright (c) Mysten Labs, Inc.', ' SPDX-License-Identifier: Apache-2.0'],
+		],
+		'@typescript-eslint/no-unused-vars': [
+			'error',
+			{
+				argsIgnorePattern: '^_',
+				varsIgnorePattern: '^_',
+				vars: 'all',
+				args: 'none',
+				ignoreRestSiblings: true,
+			},
+		],
+	},
+	overrides: [
+		{
+			files: ['sdk/**/*'],
+			rules: {
+				'require-extensions/require-extensions': 'error',
+				'require-extensions/require-index': 'error',
+				'@typescript-eslint/consistent-type-imports': ['error'],
+				'import/consistent-type-specifier-style': ['error', 'prefer-top-level'],
+				'import/no-cycle': ['error'],
+			},
+		},
+		{
+			files: ['apps/wallet/**/*'],
+			rules: {
+				'react/display-name': 'off',
+				'import/no-duplicates': ['error'],
+				'@typescript-eslint/consistent-type-imports': [
+					'error',
+					{
+						prefer: 'type-imports',
+						disallowTypeAnnotations: true,
+						fixStyle: 'inline-type-imports',
+					},
+				],
+				'@typescript-eslint/unified-signatures': 'error',
+				'@typescript-eslint/parameter-properties': 'error',
+				'no-console': ['warn'],
+				'@typescript-eslint/no-non-null-assertion': 'off',
+			},
+		},
+		{
+			files: ['apps/wallet/src/**/*.test.*', 'apps/wallet/src/**/*.spec.*'],
+
+			rules: {
+				// Allow any casting in tests:
+				'@typescript-eslint/no-explicit-any': 'off',
+			},
+		},
+		{
+			files: ['dapps/kiosk/**/*'],
+			rules: {
+				'no-unused-vars': 'off', // or "@typescript-eslint/no-unused-vars": "off",
+				'unused-imports/no-unused-imports': 'error',
+				'unused-imports/no-unused-vars': [
+					'warn',
+					{
+						vars: 'all',
+						varsIgnorePattern: '^_',
+						args: 'after-used',
+						argsIgnorePattern: '^_',
+					},
+				],
+			},
+		},
+		{
+			files: ['sdk/ledgerjs-hw-app-sui/**/*', 'apps/wallet/**/*'],
+			rules: {
+				// ledgerjs-hw-app-sui and wallet use Buffer
+				'no-restricted-globals': ['off'],
+				'@typescript-eslint/ban-types': ['off'],
+			},
+		},
+		{
+			files: ['*.test.*', '*.spec.*'],
+			rules: {
+				// Tests can violate extension rules:
+				'require-extensions/require-extensions': 'off',
+				'require-extensions/require-index': 'off',
+				'@typescript-eslint/consistent-type-imports': ['off'],
+				'import/consistent-type-specifier-style': ['off'],
+				// Reset to defaults to allow `Buffer` usage in tests (given they run in Node and do not impact bundle):
+				'no-restricted-globals': ['off'],
+				'@typescript-eslint/ban-types': ['error'],
+			},
+		},
+		{
+			files: ['*.stories.*'],
+			rules: {
+				// Story files have render functions that this rule incorrectly warns on:
+				'react-hooks/rules-of-hooks': 'off',
+			},
+		},
+		{
+			files: ['sdk/create-dapp/templates/**/*'],
+			rules: {
+				'header/header': 'off',
+				'require-extensions/require-extensions': 'off',
+			},
+		},
+	],
+};

.gitattributes

@@ -7,6 +7,6 @@ crates/sui-core/tests/staged/sui.yaml text eol=lf
 crates/sui-open-rpc/spec/openrpc.json text eol=lf
 sui_core/tests/staged/sui.yaml text eol=lf
 
-# These files is auto generated
-sdk/typescript/src/index.guard.ts linguist-generated=true
-sdk/typescript/src/rpc/client.guard.ts linguist-generated=true
+# These files are auto generated
+sdk/graphql-transport/src/queries/generated.ts linguist-generated=true
+sdk/typescript/src/graphql/generated/** linguist-generated=true