This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
Add sorting by downloads #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amorymeltzer
commented
Apr 2, 2021
| @@ -783,7 +785,7 @@ With prefix N, move to the N-th previous package instead." | |||
| ("star," "visit homepage," "unmark," ("mark Upgrades," . 5) "~delete obsolete") | |||
| ("list commits") | |||
| ("filter by" "+" "upgrades" "regexp" "keyword" "starred" "clear") | |||
| ("Sort by" "+" "Package name" "Status" "*(star)"))) | |||
| ("Sort by" "+" "Package name" "Status" "*(stars)" "↓(downloads)"))) | |||
There was a problem hiding this comment.
Made it stars not star, figured that was correct.
Amorymeltzer
commented
Apr 2, 2021
Comment on lines
730
to
+731
| ["By Number of Stars" paradox-sort-by-★] | ||
| ["By Number of Downloads" paradox-sort-by-↓] |
There was a problem hiding this comment.
I matched the previous behavior, but probably better to make use of paradox--column-name-star and paradox--column-name-download rather than hardcode. See also #187
Amorymeltzer
added a commit
to Amorymeltzer/dotfiles
that referenced
this pull request
Apr 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful in particular for non-GitHub packages, as well as packages out of the limelight.
For anyone interested, just adding
(paradox--define-sort paradox--column-name-download "d")to your startup file should make this available in the meantime. (see #176 (comment) if they're not visible)