This repository has been archived by the owner on Oct 21, 2022. It is now read-only.
Update 'paradox--package-repo-list' even if the repos hasn't star #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* helpers/paradox-counter.el: decorrelate update of 'paradox--package-repo-list' from counting stars.
Malabarba
suggested changes
May 12, 2020
helpers/paradox-counter.el
Outdated
Comment on lines
106
to
109
| (let ((count (paradox-fetch-star-count .repo))) | ||
| (when (numberp count) | ||
| (puthash name count paradox--star-count))) | ||
| (puthash name .repo paradox--package-repo-list))) |
There was a problem hiding this comment.
Looks like the indentation is a bit off here because you're using tabs. Could you switch to spaces?
There was a problem hiding this comment.
Hope the last commit fix this.
|
Hey there, thanks for the PR. |
* helpers/paradox-counter.el: untabify last change.
|
May be I'm wrong, but it seem to me this file is used to check the repo is from github before allowing you to retrieve commit list. |
|
ping ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decorrelate update of 'paradox--package-repo-list' from counting stars.