Fix controller issues #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracc
reviewed
Dec 30, 2020
|
|
||
| // Update controllers roughly every second | ||
| if(frame_counter % 60 == 0) { | ||
| update_controllers(); |
There was a problem hiding this comment.
I'm certified stupid, but wouldn't this attempt to open the same gamecontroller(s) once every second?
There was a problem hiding this comment.
Correct. This should allow controllers to be plugged in after the app is loaded. Looks to me to be pretty safe to call this often. https://github.com/XboxDev/nxdk-sdl/blob/a2a2d9ca1a5a7082c830490a0b110829939de3a7/src/joystick/SDL_gamecontroller.c#L1548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix the issue and workaround described in issue #6.
While this isn't a fix for the possible upstream bug, I do believe it's a suitable workaround and should serve the usage of the app even after the issue is resolved.