Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show contract_resource_distributed chart #266

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

zmcNotafraid
Copy link
Member

@zmcNotafraid zmcNotafraid commented Mar 15, 2024

Magickbase/ckb-explorer-public-issues#500


Needs to change REACT_BASE_URL to REACT_APP_BASE_URL

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 8:53am

@Keith-CY Keith-CY requested a review from FrederLu March 15, 2024 08:35
@Keith-CY
Copy link
Member

I found that the chat is empty while data are returned in the API
https://ckb-explorer-frontend-in-magickbase-repo-git-c5c256-magickbase.vercel.app/charts/contract-resource-distributed
image

src/locales/en.json Outdated Show resolved Hide resolved
@FrederLu
Copy link

contract-resource-distributed.csv
image
There is data in the downloaded file, but the icon appears blank.

@FrederLu
Copy link

FrederLu commented Mar 20, 2024

image

https://pudge.explorer.nervos.org/en/script/0x85ae4db0dd83f428a31deb342e4000af37ce2c9645d9e619df00096e3c50a2bb/type/referring_cells?page=1&size=10

The chart uses staging data. Clicking the script name will jump to the testnet, and the data does not match.
It was found that the corresponding unique address used data on the godwoken_custodian_lock chart was unreasonable.


image The hover data on the `y` axis is prominent and needs to be optimized for display.

@FrederLu
Copy link

image image image

Since the amount of data is large and easy to display, the ordinate value can be displayed with unit style, refer to Transaction Fee.

@Keith-CY Keith-CY merged commit 7175484 into Magickbase:develop Mar 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants