feat: update threshold of halving countdown #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the countdown of halving, and shows "Coming soon" info when countdown less than or equal to 3 seconds
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Here itself is a buffer time reserved for service responses that need to be queried for successful activation in the chain. Here 3 seconds in advance would be better, and can be adapted to the case of immediate effect. |
WhiteMinds
approved these changes
Nov 9, 2023
PainterPuppets
approved these changes
Nov 9, 2023
|
@FrederLu please have a review at this update |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the countdown shows "Coming soon" after `Halving Countdown 0 Seconds", it's a bit confusing because "Halvd" is expected when the countdown lefts 0s.
This PR moves the threshold of "Coming soon" to 3s as a buffer.
Screen.Recording.2023-11-09.at.13.08.18.mov