Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: hide script item from list if its deployment info is not set #140

Merged
merged 2 commits into from
Nov 9, 2023
Merged

feat: hide script item from list if its deployment info is not set #140

merged 2 commits into from
Nov 9, 2023

Conversation

Keith-CY
Copy link
Member

@Keith-CY Keith-CY commented Nov 7, 2023

No description provided.

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 10:24am

@Keith-CY Keith-CY requested a review from WhiteMinds November 8, 2023 01:32
WhiteMinds
WhiteMinds approved these changes Nov 8, 2023
View reviewed changes
Copy link

@WhiteMinds WhiteMinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The {script ? (...) : null} in the following code can be directly changed to (...) .

@Keith-CY
Copy link
Member Author

Keith-CY commented Nov 8, 2023

The {script ? (...) : null} in the following code can be directly changed to (...) .

I can get the point but I didn't find corresponding code

@WhiteMinds
Copy link

I can get the point but I didn't find corresponding code

https://github.com/Magickbase/ckb-explorer-frontend/pull/140/files#diff-e88da1105bbd0d05a526c1ad5da6e9361e6c5ee3fe3e97a31c301e0332272fc6R230-R240

@Keith-CY
Copy link
Member Author

Keith-CY commented Nov 8, 2023

I can get the point but I didn't find corresponding code

#140 (files)

Updated by fdc6fd6

@Keith-CY Keith-CY added this pull request to the merge queue Nov 9, 2023
Merged via the queue into develop with commit 01495d0 Nov 9, 2023
5 checks passed
@Keith-CY Keith-CY deleted the hide-script-item-if-info-is-not-found branch November 9, 2023 16:54
Keith-CY added a commit that referenced this pull request Nov 15, 2023
@Keith-CY
feat: hide script item from list if its deployment info is not set (#140
1588a03 
)

* feat: hide script item from list if its deployment info is not set

* refactor: remove useless ternary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhiteMinds WhiteMinds WhiteMinds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keith-CY @WhiteMinds