Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missed pagination from the page of transactions, referring cells and deployed cells. #113

Merged
merged 5 commits into from
Oct 16, 2023

Conversation

Daryl-L
Copy link

@Daryl-L Daryl-L commented Oct 7, 2023

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 5:31am

@FrederLu
Copy link

FrederLu commented Oct 7, 2023

There are 2 styling issues with the UI on mobile:

  1. When paging, there is no need to display a white bottom frame below the operation bar;
  2. The right margin of the "GoTo" button is too small, please refer to UI adjustment;
image image

@Daryl-L
Copy link
Author

Daryl-L commented Oct 12, 2023

There are 2 styling issues with the UI on mobile:

  1. When paging, there is no need to display a white bottom frame below the operation bar;
  2. The right margin of the "GoTo" button is too small, please refer to UI adjustment;

image image

done

@FrederLu
Copy link

There are 2 styling issues with the UI on mobile:

  1. When paging, there is no need to display a white bottom frame below the operation bar;
  2. The right margin of the "GoTo" button is too small, please refer to UI adjustment;

image image

done

https://ckb-explorer-frontend-in-magickbase-repo-k2glzivhd-magickbase.vercel.app/script/0x9bd7e06f3ecf4be0f2fcd2188b23f1b9fcc88e5d4b65a8637b17723bbda3cce8/type
@Daryl-L
Problem 1 still exists. Issue 2 has been fixed.
Please confirm.

image

@Daryl-L
Copy link
Author

Daryl-L commented Oct 13, 2023

There are 2 styling issues with the UI on mobile:

  1. When paging, there is no need to display a white bottom frame below the operation bar;
  2. The right margin of the "GoTo" button is too small, please refer to UI adjustment;

image image

done

https://ckb-explorer-frontend-in-magickbase-repo-k2glzivhd-magickbase.vercel.app/script/0x9bd7e06f3ecf4be0f2fcd2188b23f1b9fcc88e5d4b65a8637b17723bbda3cce8/type @Daryl-L Problem 1 still exists. Issue 2 has been fixed. Please confirm.

image

I missed it and it was done just now in 994f730

@FrederLu
Copy link

FrederLu commented Oct 13, 2023

I missed it and it was done just now in 994f730

This modification was successful and the bottom is now normal.
image
But I found that Code Hash and Type Id were displayed incorrectly, and Referring Cells (4,267,580) was partially obscured. Need to confirm whether this modification caused the error.
https://ckb-explorer-frontend-in-magickbase-repo-7ymtfcixc-magickbase.vercel.app/script/0x9bd7e06f3ecf4be0f2fcd2188b23f1b9fcc88e5d4b65a8637b17723bbda3cce8/type?page=1&size=10
image

@Daryl-L
Copy link
Author

Daryl-L commented Oct 16, 2023

I missed it and it was done just now in 994f730

This modification was successful and the bottom is now normal. image But I found that Code Hash and Type Id were displayed incorrectly, and Referring Cells (4,267,580) was partially obscured. Need to confirm whether this modification caused the error. https://ckb-explorer-frontend-in-magickbase-repo-7ymtfcixc-magickbase.vercel.app/script/0x9bd7e06f3ecf4be0f2fcd2188b23f1b9fcc88e5d4b65a8637b17723bbda3cce8/type?page=1&size=10 image

done

@Keith-CY Keith-CY merged commit 65a1284 into develop Oct 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants