Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use X instead of twitter #109

Merged
merged 2 commits into from
Sep 28, 2023
Merged

feat: use X instead of twitter #109

merged 2 commits into from
Sep 28, 2023

Conversation

Keith-CY
Copy link
Member

@vercel
Copy link

vercel bot commented Sep 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 6:50am

@Keith-CY Keith-CY mentioned this pull request Sep 28, 2023
Closed
@FrederLu
Copy link

The new icon has been changed, but does it need to have the system color change like other icons when the mouse hovers?

12.mov

@Keith-CY
Copy link
Member Author

The new icon has been changed, but does it need to have the system color change like other icons when the mouse hovers?

12.mov

My fault, it should be colored on hover

@Keith-CY
Copy link
Member Author

The new icon has been changed, but does it need to have the system color change like other icons when the mouse hovers?

12.mov

It should be fixed by 33f171f

@Keith-CY Keith-CY merged commit e825bd9 into develop Sep 28, 2023
5 checks passed
@Keith-CY Keith-CY deleted the update-twitter-to-x branch September 28, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederLu FrederLu FrederLu approved these changes

@PainterPuppets PainterPuppets PainterPuppets approved these changes

@zhangyouxin zhangyouxin Awaiting requested review from zhangyouxin

@Daryl-L Daryl-L Awaiting requested review from Daryl-L

@WhiteMinds WhiteMinds Awaiting requested review from WhiteMinds

@silySuper silySuper Awaiting requested review from silySuper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Keith-CY @FrederLu @PainterPuppets