Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typeId): show type id from the property "id" in response #105

Merged
merged 2 commits into from
Oct 7, 2023
Merged

feat(typeId): show type id from the property "id" in response #105

merged 2 commits into from
Oct 7, 2023

Conversation

Daryl-L
Copy link

@Daryl-L Daryl-L commented Sep 24, 2023

show the type id in detail page of script from id property in response

@vercel
Copy link

vercel bot commented Sep 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 3:19am

@Daryl-L Daryl-L mentioned this pull request Sep 24, 2023
Closed
@FrederLu
Copy link

FrederLu commented Sep 25, 2023 •
edited
Loading

@Daryl-L
The type id is displayed, but the style needs to be adjusted with reference to code hash.
image

@Daryl-L
Copy link
Author

Daryl-L commented Oct 7, 2023

@Daryl-L The type id is displayed, but the style needs to be adjusted with reference to code hash. image

done

@Keith-CY Keith-CY added this pull request to the merge queue Oct 7, 2023
Merged via the queue into develop with commit b0d73bb Oct 7, 2023
5 checks passed
@Keith-CY Keith-CY deleted the feature/typeId branch October 7, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederLu FrederLu FrederLu approved these changes

@WhiteMinds WhiteMinds WhiteMinds approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@zhangyouxin zhangyouxin Awaiting requested review from zhangyouxin

@PainterPuppets PainterPuppets Awaiting requested review from PainterPuppets

@silySuper silySuper Awaiting requested review from silySuper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Daryl-L @FrederLu @Keith-CY @WhiteMinds