-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiturn conversation error Groq #312
Fix multiturn conversation error Groq #312
Conversation
* Groq assistant turns can only have `content: <str>`, no arrays or multimodal * Groq cannot handle response_format argument the way that its passed, I'm working on a separate commit for that.
I'm working on getting Groq to handle response formatting I got it working in some tests, don't merge yet |
https://open.bigmodel.cn/ has the same problem, ignores historical messages |
I'm not sure we should add response format to this because it opinionates the library with a specific prompt |
Yeah let's go with that for now. I do want to support a high level resposne format library like instructor but built on top of ell, but maybe not inside of ell. Like ell-structure or something liek this that has the following syntax:
|
@MadcowD Is there any good reason not to leverage Instructor for that? It is widely used and better to not reinvent the wheel if it works well. Also, if I understand correctly, adjusting the system prompt is one of the techniques Instructor uses to coerce tool use and structured responses. |
@reecelikesramen i prefer folks ot use instructor and override the client etc (see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment
3a20f32
to
3562d14
Compare
@MadcowD here, I reverted to the first commit of this PR which handles just the stated issue |
Wooo thank you |
Fixes #289
content: <str>
, no arrays or multimodal