Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiturn conversation error Groq #312

Merged

Conversation

reecelikesramen
Copy link

Fixes #289

  • Groq assistant turns can only have content: <str>, no arrays or multimodal
  • Warning that Groq cannot handle response_format argument: This is because the way that its passed, I'm working on a separate commit for that.

* Groq assistant turns can only have `content: <str>`, no arrays or multimodal
* Groq cannot handle response_format argument the way that its passed, I'm working on a separate commit for that.
@reecelikesramen
Copy link
Author

I'm working on getting Groq to handle response formatting I got it working in some tests, don't merge yet

@reecelikesramen
Copy link
Author

@reecelikesramen reecelikesramen marked this pull request as ready for review October 16, 2024 03:42
@realjustinwu
Copy link

https://open.bigmodel.cn/ has the same problem, ignores historical messages

@MadcowD
Copy link
Owner

MadcowD commented Oct 20, 2024

I'm not sure we should add response format to this because it opinionates the library with a specific prompt

@reecelikesramen
Copy link
Author

reecelikesramen commented Oct 20, 2024 via email

@MadcowD
Copy link
Owner

MadcowD commented Oct 24, 2024

Yeah let's go with that for now. I do want to support a high level resposne format library like instructor but built on top of ell, but maybe not inside of ell. Like ell-structure or something liek this that has the following syntax:

@ell.structure(model=..., resposne_format=....)

@reecelikesramen
Copy link
Author

@MadcowD Is there any good reason not to leverage Instructor for that? It is widely used and better to not reinvent the wheel if it works well. Also, if I understand correctly, adjusting the system prompt is one of the techniques Instructor uses to coerce tool use and structured responses.

@MadcowD
Copy link
Owner

MadcowD commented Oct 29, 2024

@reecelikesramen i prefer folks ot use instructor and override the client etc (see instructor_ex) file for now. I'd like to merge this but I need you to remvoet he "resposne_format" stuff would you mind doing that so we don't add a system prompt to the library?

Copy link
Owner

@MadcowD MadcowD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

@reecelikesramen reecelikesramen force-pushed the fix/289-groq-provider-api-error branch from 3a20f32 to 3562d14 Compare October 29, 2024 01:34
@reecelikesramen
Copy link
Author

@MadcowD here, I reverted to the first commit of this PR which handles just the stated issue

@MadcowD MadcowD merged commit a80e0b1 into MadcowD:main Oct 29, 2024
6 checks passed
@MadcowD
Copy link
Owner

MadcowD commented Oct 29, 2024

Wooo thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groq client api error
3 participants