Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #310 but also autocommit when no OpenAI key present #311

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

reecelikesramen
Copy link

@reecelikesramen reecelikesramen commented Oct 15, 2024

  • OpenAI API requires there be a api_key field although Ollama's API doesn't require it
  • Fixed _autocommit_warning to warn when there's no client for config.autocommit_model instead of hardcoded "gpt-4o-mini" string and updated warning message accordingly
    Autocommit not working for Ollama models #310

* OpenAI API requires there be a `api_key` field although Ollama's API doesn't require it
* Fixed `_autocommit_warning` to warn when there's no client for config.autocommit_model instead of hardcoded "gpt-4o-mini" string and updated warning message accordingly
@reecelikesramen reecelikesramen changed the title Fix issue 310 but also autocommit when no OpenAI key present Fix issue #310 but also autocommit when no OpenAI key present Oct 15, 2024
@reecelikesramen
Copy link
Author

@MadcowD could you merge this? #310 just got bumped again

@MadcowD MadcowD merged commit 612aa39 into MadcowD:main Oct 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants