Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

homework done #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

homework done #1

wants to merge 2 commits into from

Conversation

panasetskaya
Copy link

homework done

Antol
Antol approved these changes Feb 24, 2022
View reviewed changes
src/main.kt

// Вернуть количество клментов из выбранного города
fun Shop.countCustomersFrom(city: City): Int = 0
fun Shop.countCustomersFrom(city: City): Int = customers.filter { it.city==city }.toSet().size
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошо, но можно просто customers.count{ it.city == city }

src/main.kt

// Вернуть словарь в котором названия городов являются ключами, а значениями - сет клиентов, проживающих в этом городе
fun Shop.groupCustomersByCity(): Map<String, Set<Customer>> = mapOf()
fun Shop.groupCustomersByCity(): Map<String, Set<Customer>> {
val cities = getCitiesCustomersAreFrom()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Интересно, не подумал что можно другие функцию использовать, но не очень по оптимальности решение получается, много лишнего. Так проще
customers.groupBy { it.city.title }.mapValues { it.value.toSet() }

src/main.kt

// Вернуть сет клиентов, у которых не доставленных заказов больше чем заказанных
fun Shop.getCustomersWithMoreUndeliveredOrdersThanDelivered(): Set<Customer> = setOf()
fun Shop.getCustomersWithMoreUndeliveredOrdersThanDelivered(): Set<Customer> =
customers.filter{ (it.orders.filter { !it.isDelivered }.size) > (it.orders.filter { it.isDelivered }.size)}.toSet()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ок. Можно было еще через partition, чуть читабельнее (для тех кто знаком с такой функцией конечно)

customers.filter {
    val (del, undel) = it.orders.partition { it.isDelivered }
    undel.count() > del.count()
}.toSet()

src/main.kt
fun Customer.getMostExpensiveDeliveredProduct(): Product? {
val products = orders.filter{it.isDelivered}.flatMap {it.products}
val maxPrice = products.maxOfOrNull { it.price }
return products.find { it.price==maxPrice }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Можно без создания дополнительных переменных
orders.filter { it.isDelivered }.flatMap { it.products }.maxByOrNull { it.price }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antol Antol Antol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panasetskaya @Antol