Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type fix: ChatResult > ChatStreamResult #173

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

kalafus
Copy link
Contributor

@kalafus kalafus commented Feb 14, 2024

What

type fix in OpenAI.chatsStream: ChatResult > ChatStreamResult
typo: performSteamingRequest > performStreamingRequest

Why

chatStream result return type is ChatStreamResult, but the performStreamingRequest request parameter indicates ChatResult.

Fix the typo Steaming > Streaming too.

Affected Areas

OpenAI.chatStream

Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@ingvarus-bc ingvarus-bc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🔥

@ingvarus-bc ingvarus-bc merged commit 1f6d1c0 into MacPaw:main Feb 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants