Codable > Encodable | Decodable #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 7, 2024 12:22
… instead of Codable for everything
|
Hey, @kalafus, thanks for your contribution! ✨
It seems like tests here require some fixing now too 🙏🏼 |
|
had to add a surprising amount of code due to an error that extensions for the Encodable protocol won't automatically implement this way... but it's done. have any ideas to de-duplicate? there's got to be a better way! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
be specific with Codable:
use
Encodable for queries,
Decodable for results,
instead of Codable for everything
Why
accurate inheritance prevents accidental misuse
Affected Areas
JSON encoding and decoding during networking
NOTE
I don't know what to do with the .stub() functions, which require that Responses are Encodable for testing purposes, when Responses should only have to be Decodable.