Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search.py #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RGAlexander216
Copy link

@RGAlexander216 RGAlexander216 commented Feb 26, 2023

  • Added the ability to specify the simple_or_comprehensive as an explicit string as well as a SearchEngine.SimpleOrComprehensiveEnum object
  • Added type conversion for the lat, lng, and radius parameters in the SearchEngine class' query method with descriptive error handling

Added the ability to specify the simple_or_comprehensive as an explicit string as well as a SearchEngine.SimpleOrComprehensiveEnum object
Added type conversion for the lat, lng, and radius parameters in the SearchEngine class' query method with descriptive error handling
@RGAlexander216 RGAlexander216 changed the title Update search.py (final revision) Update search.py Feb 26, 2023
@MacHu-GWU
Copy link
Owner

Good ideal, the right way to implement this should be. I will borrow your idea about the int-like float-like, and add you to the contributor list. Thank you

class XYZEnum(str, enum.Enum):
   ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants