Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2036 #2115

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix #2036 #2115

merged 1 commit into from
Aug 7, 2024

Conversation

RTChou
Copy link
Contributor

@RTChou RTChou commented Aug 7, 2024

What does this PR do?

This PR fixes ValueError when computing weighted average embeddings of seeded topic and documents in the context of Guided Topic Modeling. To solve the issue, direct NumPy array computation is implemented instead of using the np.average() function.

Fixes #2036

Before submitting

  • This PR fixes a typo or improves the docs (if yes, ignore all other checks!).
  • Did you read the contributor guideline?
  • Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes (if applicable)?
  • Did you write any new necessary tests?

@MaartenGr
Copy link
Owner

Awesome, thanks for this. LGTM!

@MaartenGr MaartenGr merged commit a095e58 into MaartenGr:master Aug 7, 2024
6 checks passed
@RTChou RTChou deleted the fix_2036 branch August 7, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Guided Topic Modeling] ValueError: setting an array element with a sequence.
2 participants