Add "no results" messages pointing to new voucher system #707
+56
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #707 +/- ##
======================================
Coverage ? 54.29%
======================================
Files ? 170
Lines ? 7349
Branches ? 0
======================================
Hits ? 3990
Misses ? 3359
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Usually `click()` should already do this for us I thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via #670 and #671, users (e.g. teachers) can no longer search other users in the whole MaMpf database in order to assign them as tutors, speakers, teachers and editors. Instead, they now have to use the new voucher system, i.e. generate a voucher that users can redeem to obtain the "tutor status". The teacher can then assign them as tutor. All of this is to be GDPR-compliant.
This PR improves the
No results messagein search boxes that previously allowed to search for arbitrary users. This is to avoid confusion and to give guidance on what to do now. For example: