-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign profile page #706
base: dev
Are you sure you want to change the base?
Conversation
Also I just noticed that the blue color of the top navigational bar does not match with the blue of the panels. The difference is subtle, therefore I am unsure if its intentional or not. Not a huge deal, but now that I have seen it, I will never unsee it :D |
Yeah, thank you, that looks quite nice. Could you maybe share the code or just directly apply a commit to this branch to change the pattern?
It does match, but only with the left side ;) It's a gradient from the darker to a lighter blue to the right. We could maybe change the left point to be a bit more to the right. |
Signed-off-by: Florian <[email protected]>
…sign/profile-page
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #706 +/- ##
======================================
Coverage ? 54.27%
======================================
Files ? 170
Lines ? 7348
Branches ? 0
======================================
Hits ? 3988
Misses ? 3360
Partials ? 0 ☔ View full report in Codecov by Sentry. |
We completely redesign the profile page as follow up for #670 and #671.
Request data
modal and make the button less prominent. This is to avoid confusion since in the past many users mistook it for theSave changes
button (it was previously placed at the bottom of the page with primary color). If the user really requests the data, we now show a toast and stay on the page.Unsaved changes
warning is now shown immediately when typing (not just when clicking away from an input field). We also style it such that the warning itself is a button along its full width (makes it easier clickable and reduces mouse motion).570px
are not supported. For this to work, we'd have to also change the code in other places like the navbar.Further changes:
Known limitations
Change login data
button continues to redirect to the MaMpf landing page, which should only be shown when the user is not logged in. This could be tackled in a future PR, e.g. by introducing another modal on the profile edit page.Redesign preview
Expand
Before
After