Add yapf checker #1695
Open
Add yapf checker #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alastair
force-pushed
the
check-yapf
branch
from
0abb295
to
9e07e53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have discussed in the past that we want to add a code formatter to freesound in order to be consistent with everything!
This PR adds an action to check formatting with yapf. We had a small discussion about using yapf vs black and yapf edged out slightly.
I've not used this yapf-action before, previously I just installed yapf manually and ran it. We need to check if it works correctly with pyproject.toml
Obviously, no actual formatting in this PR (yet!), let's see what happens!Might need to be careful with existing py2 code.