Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a sample flake8 linting check to freesound. It's based on a generic linter setup that I have in some other projects.
I'm just interested in seeing what kind of errors are reported - it's possible that we might decide that all of these tests are terrible and not really useful. Let's see what happens and if the kind of reports are useful. We can remove checks as necessary if we don't like them, or consider looking at other flak8 plugins to see if we want to add more
I added a basic config file, but we should also consider moving it to a pyproject.toml
It would be nice to use github's built in pip cache to speed up installation.
I've previously had problems with this action, as there are no versions specified in the requirements file. So if a new version introduces new checks, suddenly an unrelated change will result in a bunch of failures. We should consider how we define our dependencies (in a separate linting file, or as part of the dev dependencies?), and decide how we want to specify versions.