Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev - introduced docker-compose for local env #87

Merged
merged 19 commits into from
Mar 19, 2024
Merged

Dev - introduced docker-compose for local env #87

merged 19 commits into from
Mar 19, 2024

Conversation

lwih
Copy link
Collaborator

@lwih lwih commented Feb 2, 2024

No description provided.

Copy link

gitguardian bot commented Feb 2, 2024

⚠️ GitGuardian has uncovered 32 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9429425 Triggered Generic Password db0e836 infra/docker-compose.local.yml View secret
9429425 Triggered Generic Password f2c1ced infra/docker-compose.yml View secret
9429425 Triggered Generic Password db0e836 infra/configurations/backend/application-prod.properties View secret
9429425 Triggered Generic Password db0e836 backend/src/main/resources/application.properties View secret
9429425 Triggered Generic Password df2f13f infra/docker-compose.local.yml View secret
9429425 Triggered Generic Password db0e836 infra/configurations/backend/application-local.properties View secret
9429425 Triggered Generic Password db0e836 infra/configurations/backend/application-dev.properties View secret
9429425 Triggered Generic Password 26fd0ab docker-compose.yml View secret
9429425 Triggered Generic Password df2f13f infra/docker-compose.local.yml View secret
9429425 Triggered Generic Password db0e836 backend/src/main/resources/application.properties View secret
9429425 Triggered Generic Password d7c3624 infra/configurations/backend/application-dev.properties View secret
9429425 Triggered Generic Password db0e836 infra/docker-compose.local.yml View secret
9429425 Triggered Generic Password d7c3624 infra/configurations/backend/application-prod.properties View secret
9429425 Triggered Generic Password db0e836 infra/configurations/backend/application-dev.properties View secret
9429425 Triggered Generic Password db0e836 infra/configurations/backend/application-prod.properties View secret
9429425 Triggered Generic Password d7c3624 infra/configurations/backend/application-local.properties View secret
9429425 Triggered Generic Password db0e836 infra/configurations/backend/application-dev.properties View secret
9429425 Triggered Generic Password d7c3624 infra/configurations/backend/application-prod.properties View secret
9429425 Triggered Generic Password db0e836 infra/configurations/backend/application-dev.properties View secret
9429425 Triggered Generic Password 26fd0ab docker-compose.yml View secret
9429425 Triggered Generic Password d7c3624 infra/configurations/backend/application-dev.properties View secret
9429425 Triggered Generic Password d7c3624 infra/configurations/backend/application-local.properties View secret
9429425 Triggered Generic Password db0e836 infra/configurations/backend/application-local.properties View secret
9429425 Triggered Generic Password d7c3624 backend/src/main/resources/application.properties View secret
9429425 Triggered Generic Password db0e836 infra/docker-compose.prod.yml View secret
9429425 Triggered Generic Password db0e836 infra/docker-compose.local.yml View secret
9429425 Triggered Generic Password e7bfc2d infra/configurations/backend/application-local.properties View secret
9429425 Triggered Generic Password 8b38d2a backend/target/classes/application.properties View secret
9429425 Triggered Generic Password e7bfc2d backend/src/main/resources/application.properties View secret
9976149 Triggered GitLab Token e9c667f infra/docker-compose.local.yml View secret
9976149 Triggered GitLab Token 1a275ad infra/docker-compose.local.yml View secret
9976149 Triggered GitLab Token ffcd9a1 docker-compose.yml.j2 View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Copy link

github-actions bot commented Feb 2, 2024

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 78.59% (🎯 70%) 1131 / 1439
🟢 Statements 79.05% (🎯 70%) 1170 / 1480
🟢 Functions 73.03% (🎯 70%) 298 / 408
🟢 Branches 71.79% (🎯 70%) 504 / 702
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
frontend/src/apollo-client.ts 55.55% 16.66% 0% 55.55% 23-31, 35, 37-40, 38-39, 42
frontend/src/app.tsx 92.85% 50% 100% 92.85% 52-62
frontend/src/index.tsx 0% 100% 100% 0% 13, 15-20
frontend/src/sentry.ts 0% 100% 0% 0% 7, 9-37, 10-13, 15-36
frontend/src/pam/mission/page-header.tsx 80% 50% 50% 80% 65-66
frontend/src/pam/missions/missions.tsx 81.81% 75% 50% 81.81% 15-18, 90
Generated in workflow #313

Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

2 Security Hotspots

See analysis details on SonarCloud

@lwih lwih force-pushed the metabase-crud branch 2 times, most recently from 75e5ee0 to cb1f041 Compare February 27, 2024 14:47
@lwih lwih force-pushed the metabase-crud branch 3 times, most recently from 21f111c to aba4220 Compare March 11, 2024 18:47
@lwih
Copy link
Collaborator Author

lwih commented Mar 11, 2024

Note to self:

  • attendre réponse DSI sur les env vars + secrets
  • rajouter les frontend secrets dans docker (cf ADR)
  • modifier vars/secrets dans application-x.properties

@lwih lwih merged commit 4b1bd6a into main Mar 19, 2024
9 of 10 checks passed
@lwih lwih deleted the metabase-crud branch March 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant