-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mission-crew): Refacto mission-crew with comment #156
Merged
xtiannyeto
merged 7 commits into
main
from
feature/layout-add-team-member-update-list-with-comment
May 30, 2024
Merged
feat(mission-crew): Refacto mission-crew with comment #156
xtiannyeto
merged 7 commits into
main
from
feature/layout-add-team-member-update-list-with-comment
May 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xtiannyeto
commented
May 23, 2024
- Create a new list of crew member layout with comment
- Display a Dialog for adding a new member or updating an existing one
- Add a form with validation
- trigger delete / addOrUpdateCrew mutation
- tests
- Add truncate attribute to Text - Test style of truncate Text
- Add provide middleware removeTypenameLink in apollo link to remove nested __typename
- Dialog component + form agent, role - yup schema for validation - execute handle Submit provided parent component
- render the list of crew member - render action edit and delete
- add comment in the response addOrUpdateCrew - Add modal form and member crewlist compoenent - trigger delete and addOrUpdateMutation as before.
Coverage Report for frontend
File Coverage
|
- Check add member and update member
- Add value of max length on comment validation - Add test on max length validation / error message
lwih
reviewed
May 29, 2024
xtiannyeto
deleted the
feature/layout-add-team-member-update-list-with-comment
branch
May 30, 2024 13:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.