Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission-crew): Refacto mission-crew with comment #156

Merged

Conversation

xtiannyeto
Copy link
Collaborator

  • Create a new list of crew member layout with comment
  • Display a Dialog for adding a new member or updating an existing one
  • Add a form with validation
  • trigger delete / addOrUpdateCrew mutation
  • tests

 - Add truncate attribute to Text
 - Test style of truncate Text
 - Add  provide middleware removeTypenameLink in apollo link to remove nested __typename
 - Dialog component + form agent, role
 - yup schema for validation
 - execute handle Submit provided parent component
 - render the list of crew member
 - render action edit and delete
 - add comment in the response addOrUpdateCrew
 - Add modal form and member crewlist compoenent
 - trigger delete and addOrUpdateMutation as before.
Copy link

github-actions bot commented May 23, 2024

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 65.89% (🎯 50%) 1426 / 2164
🟢 Statements 66.62% (🎯 50%) 1483 / 2226
🟢 Functions 64.8% (🎯 50%) 372 / 574
🟢 Branches 58.44% (🎯 50%) 637 / 1090
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
frontend/src/apollo-client.ts 48% 16.66% 0% 48% 26-34, 38, 40-43, 41-42, 45, 52-62, 53-61
frontend/src/test-utils.tsx 100% 100% 100% 100%
frontend/src/pam/mission/crew/mission-crew-form.tsx 97.05% 100% 94.44% 96.29% 163
frontend/src/pam/mission/crew/mission-crew-member-list.tsx 100% 100% 100% 100%
frontend/src/pam/mission/crew/mission-crew.tsx 85% 72.72% 87.5% 85.29% 82, 82-83, 87-89
frontend/src/pam/mission/crew/use-add-update-mission-crew.tsx 100% 100% 100% 100%
frontend/src/ui/text.tsx 96% 95.83% 100% 96% 67
Generated in workflow #519

 - Check add member and update member
@xtiannyeto xtiannyeto linked an issue May 29, 2024 that may be closed by this pull request
 - Add value of max length on comment validation
 - Add test on max length validation / error message
@xtiannyeto xtiannyeto requested a review from lwih May 29, 2024 09:40
@xtiannyeto xtiannyeto merged commit 397e057 into main May 30, 2024
10 checks passed
@xtiannyeto xtiannyeto deleted the feature/layout-add-team-member-update-list-with-comment branch May 30, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Front: Equipage - Affichage list + Saisie avec Modal
2 participants