Address Turbo-related CSP errors on first load #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
force-pushed
the
fix/csp-turbo
branch
2 times, most recently
from
6411e76
to
24d5a1d
Compare
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 318 318
===========================================
Files 82 82
Lines 1320 1320
===========================================
Hits 1320 1320 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
florimondmanca
force-pushed
the
fix/csp-turbo
branch
from
24d5a1d
to
67da71c
Compare
florimondmanca
changed the title
mmarchois
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suite à #141
Cette PR corrige une partie des erreurs CSP qui apparaissent quand on navigue dans DiaLog (Visible en prod ou en local), du genre :
Elle supprime en effet les erreurs lors du chargement initial de la page.
Des erreurs apparaissent encore lors d'une navigation via Turbo Drive. J'ai essayé hotwired/turbo#294 (comment) mais ça n'a rien donné. J'ai ouvert un ticket sur NelmioSecurityBundle à ce sujet : nelmio/NelmioSecurityBundle#321