Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Litteralis Import : "A value containing spaces must be surrounded by quotes #1154

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

florimondmanca
Copy link
Collaborator

J'avais bien testé la CI, mais avec enabled_orgs = [] pour éviter de mettre les données en production avant de merger. Et ce problème de décodage JSON n'était donc pas visible...

La solution est copiée collée de la CI Eudonet

La difficulté c'est qu'il faut modifier les secrets si on veut pointer vers autre chose que la prod pour "tester" un job GitHub Actions. Peut-être qu'on devrait + utiliser les inputs pour pouvoir "override" les secrets quand on lance un job manuellement par workflow dispatch...

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.91%. Comparing base (fa278d0) to head (b70866c).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1154   +/-   ##
=========================================
  Coverage     98.91%   98.91%           
  Complexity     1862     1862           
=========================================
  Files           368      368           
  Lines          8018     8018           
=========================================
  Hits           7931     7931           
  Misses           87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@florimondmanca florimondmanca merged commit 23cd3b8 into main Jan 21, 2025
6 checks passed
@florimondmanca florimondmanca deleted the fix/litteralis-orgs-jsonquotes branch January 21, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants