Corrige l'export Metabase : DATABASE_URL manquant, uuid d'utilisateur actif incorrect #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1134 +/- ##
=========================================
Coverage 98.88% 98.89%
Complexity 1833 1833
=========================================
Files 366 366
Lines 7927 7929 +2
=========================================
+ Hits 7839 7841 +2
Misses 88 88 ☔ View full report in Codecov by Sentry. |
florimondmanca
changed the title
florimondmanca
force-pushed
the
fix/metabase-dialog-db
branch
from
0a0ad67 to
bcb4085
Compare
|
J'ai lancé l'import depuis cette branche et il a fonctionné Les compteurs correspondent à ceux actuellement affichés sur la page stats
|
mmarchois
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toujours pour corriger l'export Metabase...
La CI échoue encore : https://github.com/MTES-MCT/dialog/actions/runs/12649320616/job/35245478021#step:8:430
Car j'ai oublié de configurer le tunnel sur le port 10000 pour la DB applicative
dialog, je n'avais que le tunnel vers metabase sur le port 10001, y compris dans les secrets, mais du coup la connexion applicative pour calculer les stats échouait, car on utilise la database URL metabase pour accéder à la DB dialog...Bref, avec cette PR on a bien :
Elle corrige aussi un problème sur l'uuid de
analytics_user_active: j'utilisais l'UUID de l'utilisateur, mais il faut un nouvel UUID à chaque fois, comme on le faisait dans le script SQL avant de passer à PHP (voir #1116)