Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Améliorations de la modale localisation #1125

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

Lealefoulon
Copy link
Collaborator

@Lealefoulon Lealefoulon commented Dec 18, 2024

Ref #1119

Capture d’écran du 2024-12-19 11-25-17

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.88%. Comparing base (1ef6e05) to head (1e8ee2a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1125   +/-   ##
=========================================
  Coverage     98.88%   98.88%           
  Complexity     1833     1833           
=========================================
  Files           366      366           
  Lines          7927     7927           
=========================================
  Hits           7839     7839           
  Misses           88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lealefoulon Lealefoulon marked this pull request as ready for review December 18, 2024 15:38
@aureliebaton
Copy link
Collaborator

@Lealefoulon en fait c'était pour expliquer qu'on remplace "Point de début" par "Point A", et "Point de fin" par "Point B" (comme je l'ai fait dans les maquettes). Pas de garder les deux ;)

@Lealefoulon
Copy link
Collaborator Author

Lealefoulon commented Dec 19, 2024

@aureliebaton je serais tentée de laisser la taille des champs comme avant car si je réduis les champs PR et abscisse pour augmenter le champ côté voici les soucis qui se produisent au moment de changer la largeur d'écran (c'est lié au texte de desciption qui passe à la ligne en fonction de la largeur d'écran et décale tout :

Capture d’écran du 2024-12-19 11-08-42

Capture d’écran du 2024-12-19 11-08-01

Capture d’écran du 2024-12-19 11-07-16

@aureliebaton
Copy link
Collaborator

@Lealefoulon Oui je comprends, tu peux laisser comme avant alors et on verra à l'usage si c'est gênant.

Copy link
Collaborator

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impec 👍

@Lealefoulon Lealefoulon merged commit 680f44b into main Jan 7, 2025
5 of 6 checks passed
@Lealefoulon Lealefoulon deleted the fix/improve-modal-location branch January 7, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants