Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Add german language (de-DE) #198

Merged
merged 10 commits into from
Nov 26, 2020
Merged

Add german language (de-DE) #198

merged 10 commits into from
Nov 26, 2020

Conversation

dominique-mueller
Copy link
Contributor

@dominique-mueller dominique-mueller commented Nov 26, 2020

Relates to #183

Description

This PR introduces german (de-DE / de) as an additional language. Yay!

In addition, it fixes various i18n-related issues, such as

  • locale data other than english not being provided to dayjs
  • dates not being updated properly after changing language
  • tab switching no longer working with new languages / after switching language
  • prop types errors in console (pre-existing)

Checklist

  • I have run yarn format
  • I have run yarn eslint and fixed any issues
  • This PR does not add any errors to the console
  • I have added this change to the changelog

A build will automatically be run by GitHub actions when any changes are made on this PR. This must complete successfully before merging.

Screenshots or videos

Click to expand

livery-manager-de

@dominique-mueller
Copy link
Contributor Author

Not sure how to extend the changelog before an actual release, feel free to update the PR as required :)

@davwheat davwheat self-requested a review November 26, 2020 20:39
Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work on this! It's fantastic!

I've rebased your branch onto the latest commits (after merging the other language additions) and have popped it into the changelog for you :)

@davwheat davwheat merged commit b5999bd into MSFS-Mega-Pack:main Nov 26, 2020
@dominique-mueller dominique-mueller deleted the feature/translation-german branch November 26, 2020 22:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants