Pylint fixes for master branch #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not attempt to install distutils in CI. - In all locations where either shutil.which() or distutils.spawn.find_executable() is used, first attempt to import shutil.which(), and disable pylint deprecated module check on the distutils import. - Locally disable too-many-positional-arguments() on a few functions. Those in "configure" will be deprecated in 3.1.0; those in "population_template" can have a more suitable fix implemented on the development branch, but for "master" branch for now the check will simply be bypassed. - pylint.rc: - Update to reflect changes to names and expected values of those settings relating to object naming. - Disable deprecated no-space-check. - Fix overgeneral-exceptions.
Module is only loaded in the absence of shlex.quote(). This import syntax should ideally be removed entirely upon merge to development branch for inclusion in 3.1.0.
Package "python2" no longer available in GitHub CI Action.
Lestropie
force-pushed
the
pylint_master
branch
from
2d6d9bc to
c5c41a8
Compare
|
While c5c41a8 is unrelated to |
Lestropie
force-pushed
the
pylint_master
branch
from
c5c41a8 to
7ed0a5d
Compare
Lestropie
force-pushed
the
pylint_master
branch
from
4bb17f1 to
abe2a43
Compare
daljit46
previously approved these changes
Jan 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Requires a renewed review; merge failed due to needing to re-run |
daljit46
previously approved these changes
Jan 6, 2025
Lestropie
force-pushed
the
pylint_master
branch
from
06f92b4 to
049bf05
Compare
|
Sorry, need another one; forgot to run |
daljit46
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3052 is failing CI for multiple reasons. One of them is errors during
pylinttesting, presumably due to thepylintversion on the Action being incremented. Here I have addressed those issues onmaster, as well as some other Errors thatpylintraised on my own system when checkingmaster.Some changes are due to warnings about reading from uninitialised variables, which arise due to using a "
elif variable == 'string'" substitute-for-switchpattern that is not guaranteed to be exhaustive from the perspective of the linter. I tend to prefer to keep that pattern rather than using an "else:" for the last option as it's more robust to future augmentation.I have not addressed the warning about
distutilsbeing deprecated.On my local system I also get a lot of these, will wait to see if GitHub complains about it also: