-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified ocean/mesh/remap_topography
to allow smoothing
#863
Modified ocean/mesh/remap_topography
to allow smoothing
#863
Conversation
@bmooremaley, as we discussed, we'll need some way to support a different topography dataset for lower res regression testing. I pulled out the config options into their own config file: |
0475c64
to
1bd3cb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmooremaley, some preliminary comments and suggested changes while you work on the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmooremaley, a few more suggested edits. I'm extending this code in #829 to combine this topography with a dataset from MALI. That process is qualitatively similar to your modified remap_topography
so it was a useful chance to look through your code in more detail.
3e0de0b
to
37a08ef
Compare
I think the only remaining steps are:
|
…ce grid in remap_topography
Instead, we assume this has been done correctly when the SCRIP files were generated. This merge also simplifies the naming of intermediate files during file partitioning for mbtempest.
37a08ef
to
6cac480
Compare
Hoping this will prevent download failures
TestingI tested this on Chrysalis with Intel and OpenMPI. I ran the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmooremaley, thanks for very hard work on this! I took care of the last few finishing touches so I think it's ready to merge!
The
ocean/mesh/remap_topography
step has been modified to remap combined topography from a cubed sphere source grid to MPAS meshes, instead of a lat-lon source grid. The weights file generation has been switched tombtempest
so that smoothing can be defined in the target MPAS mesh SCRIP file. Smoothing parameters have been added toocean/mesh/remap_topography.cfg
. This new workflow also uses a pre-build source SCRIP file stored in the bathymetry database, in addition to the combined topography file.Checklist
Testing
in this PR) any testing that was used to verify the changes