Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Positional with a type that conforms to ArgumentGroup #15

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

roanutil
Copy link
Member

If a command A takes command B as an argument, this makes it easier to define command B as a Positional property on command A.

For example:
mise --cd {{ project path }} x tuist -- tuist version
mise is command A and tuist version is command B

feature/init-positional-with-argument-rep
feature/init-positional-with-argument-rep
feature/init-positional-with-argument-rep
feature/init-positional-with-argument-rep
feature/init-positional-with-argument-rep
feature/init-positional-with-argument-rep
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.35%. Comparing base (b2660f3) to head (8b992d3).

Files with missing lines Patch % Lines
Sources/ArgumentEncoding/PositionalArgument.swift 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   82.11%   81.35%   -0.77%     
==========================================
  Files          23       23              
  Lines        1118     1437     +319     
==========================================
+ Hits          918     1169     +251     
- Misses        200      268      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant