Fix screen code naming #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the functions that plot actual character to the screen the naming suggested it would handle PETSCII codes, where in fact is was dealing with screen codes. These changes make that more clear. This could be a breaking change for anyone who has been using fc_plotPetsciiChar in the past.
|
Renaming fcio functions is a breaking change. I suggest to introduce wrapper functions and give a deprecation warning if the old name is used. Let's also ping @steph72. Please also state if you agree with the new license (#51). |
…g when using LLVM
|
@mlund makes total sense, I was under the impression with |
mlund
reviewed
Aug 2, 2024
mlund
reviewed
Aug 2, 2024
…for non-exported function Removed deprecated asciiToPetsciicode as it was not exported in the first place. Re-added fc_plotPetsciiChar with deprecation warnings, updated doxygen comment to reflect these changes.
mlund
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Thanks a lot for your contribution!
Please tick off the following:
make test)clang-format -i <file>