[NO-MRG] Changes from Power replication #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was never meant to be merged. My main goal was/is to highlight changes I needed to make to keep CSF and WM voxels for aCompCor calculations after multi-echo denoising. Those concerns still apply, but I don't think we're going to end up adopting these specific changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes None. This PR includes changes I made to tedana for a manuscript of mine. The big problem I had to solve was that voxels necessary for CSF/WM extraction (e.g., for aCompCor) were being masked out with the adaptive mask (see #827 and NBCLab/power-replication#14).
Changes proposed in this pull request: