Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker support #4

Merged
merged 1 commit into from
Jan 6, 2024
Merged

Add Docker support #4

merged 1 commit into from
Jan 6, 2024

Conversation

rosahaj
Copy link

@rosahaj rosahaj commented Jan 6, 2024

Adds docker images for ja3proxy

  • Images are automatically built and pushed to GitHub Container Registry on each new release (through workflow)
  • Latest image is automatically tagged with latest
  • Supported architectures: amd64, arm64, armv7 (option to add more)
  • Adjusted documentation to reflect Docker usage
  • Also fixed binary releases by updating the version of the action used

@rosahaj rosahaj force-pushed the master branch 3 times, most recently from ba641d2 to 9f663d5 Compare January 6, 2024 01:05
@rosahaj rosahaj force-pushed the master branch 4 times, most recently from 1ae40ab to 79204dd Compare January 6, 2024 01:31
@LyleMi
Copy link
Owner

LyleMi commented Jan 6, 2024

Thank you very much for your excellent PR! I appreciate the time and effort you put into improving this repository. I will merge this PR as soon as possible.

Best regards, Lyle

@LyleMi LyleMi merged commit 963dd6b into LyleMi:master Jan 6, 2024
2 checks passed
@rosahaj
Copy link
Author

rosahaj commented Jan 6, 2024

Thanks for merging this so quickly! I really appreciate your project.

@rosahaj
Copy link
Author

rosahaj commented Jan 6, 2024

Since the docker workflow only runs when a new release is published, could you publish a short release (similar to https://github.com/rosahaj/ja3proxy/releases/tag/v0.2) so docker images become available?

@LyleMi
Copy link
Owner

LyleMi commented Jan 6, 2024

Sure, I'll add that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants