Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop goroutine leaks by ensuring both goroutines exit properly #14

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

huboh
Copy link
Contributor

@huboh huboh commented Jun 7, 2024

  • Use buffered channels to prevent goroutines from hanging
  • Improve stability and perf under high traffic

- Use buffered channels to prevent goroutines from hanging
- Improve stability and perf under high traffic
@pobyzaarif
Copy link

hi @LyleMi I come from upwork :)
I think this PR is good, you should test it and if it works you can merge it...

@huboh
Copy link
Contributor Author

huboh commented Jun 10, 2024

hi @LyleMi I come from upwork :)

I think this PR is good, you should test it and if it works you can merge it...

I'm from upwork also. I sent the client a proposal but he completely ignored it - I'm new on Upwork with no previous work. I just did the fix anyway

@LyleMi LyleMi merged commit e92f559 into LyleMi:master Jun 11, 2024
2 checks passed
@LyleMi
Copy link
Owner

LyleMi commented Jun 11, 2024

cool, thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants