-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Plotting optional and extendible #313
base: master
Are you sure you want to change the base?
Conversation
Does this actually fix the crash issues? |
Not sure yet, but given that |
That’s reasonable. Thanks for sorting this. I suppose we should really have a test script to make sure all the plotting functions run without error |
This just got a lot harder than I expected. Anywhere there is indexing this messes up. |
I need to leave this for now. For my future reference, this currently errors on a time_1d plot for a multimode simulation, on line |
I believe this is complete now. AFAICT all Plotting functions work with both single and multimode output. I didn;t check all of the examples. Early indications are that this doesn't fix the crashing on mac. |
This PR seems to be required now. It fixes the issue with installing conda from scratch on Ubuntu, which has existed for some people since at least March (see e.g. https://discourse.julialang.org/t/conda-not-installing-matplotlib-for-pyplot/96813/3). This is now getting more important as it prevents the new release of Luna to be auto-merged. Couple of small issues to be fixed still, working on those now. |
@chrisbrahms this has been significantly overhauled. It now uses Julia extensions to enable optional code loading. This has two big benefits:
Currently, I have implemented PythonPlot, PyPlot and Makie. They all seem to work fine. I would suggest that we recommend PythonPlot as it is the supported matplotlib interface. Personally I am using Makie more as it crashes less on mac. Still to do:
|
Use PythonPlot instead of PyPlot, to try and solve mac crash issues
This is WIP because it seems PythonPlot keeps Python 0-based indexing rather than converting to 1-based.