export_1d_elem_field numbering fixed #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the issue is not with export: it is with the set up of the 'elems' array during 'add_matching_mesh'. We should be exporting the same element and node numbering as we read in (so elems(ne), nodes(np)). |
|
Code is appropriate and the testing examples run. No impact on documentation or the example structure or outputs. |
tawhai
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the elem numbering issue in export_1d_elem_field subroutine. This issue was exporting the field correctly but the elem numbers were jumping after artery elements to capillaries and potentially writing memory address to file since it was running out of memory allocated to elements. This pull request does not need changes to examples or tests.