Issue 138 #159
Merged
Issue 138 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for initial assignment of seed points to terminal branches
|
Tried it for growing a tree for a former subject but without calling make_data_grid() subroutine. Using an old data_grid and seems like it doesn't recognise the data points to grow into. It runs through the code but doesn't create any extra elements from the Upper tree. |
|
I cannot reproduce this problem. It runs correctly for me when I read in an .ipdata file (converted from RUL.exdata in the growing_tree_Tawhai2021/output directory).
|
…ther there are >zero seed points in a group was not being initialised. the result was that tree growing worked for a pedantic build but not a release build, and only when seed points were read from file rather than generated
…xternal to a surface, by a factor of 10. fixes an issue of seed points being created outside the surface. previous tolerance allowed this when the vector from internal to seed point was very close to surface element boundaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue of growing from the lingular branch into the LUL. i.e. where growing needs to initiate from more than one 'stem' branch. Along with this have included an option for initialising seed point allocation either based on the Tawhai 2004 method (splitting planes) or Tawhai 2001 method (closest points). The latter is needed when growing from more than one stem branch.