Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Balancer Mission #13

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Tritium-VLK
Copy link

No description provided.

marshall lipman and others added 4 commits August 27, 2024 11:14
@grandmastr
Copy link
Member

_ No description provided. _

The total reward points should be added to this PR, as indicated in the doc

partners/balancer.json Show resolved Hide resolved
partners/balancer.json Show resolved Hide resolved
@Tritium-VLK
Copy link
Author

Tritium-VLK commented Aug 30, 2024

Please also note that none of the image URLs are images right now. Our design team needs to see where the images will go to make something, or at least we need some style guidelines around size/color scheme/etc.

Once we understand what needs to happen visually we can get assets together and update the PR.

Also note that it would be nice to be able to provide both URL to present Balancer, and one to present the list of pools/positions that folks should be interacting with. Right now I used the filter list, because I think users will have a hard time understanding what to do without it, and we don't want lots of chaos and confusion.

@Tritium-VLK Tritium-VLK requested a review from grandmastr August 30, 2024 18:03
Set total_points to 100 as I think this is desired
Refactored quest level points to add up to 100.
@grandmastr
Copy link
Member

Please also note that none of the image URLs are images right now. Our design team needs to see where the images will go to make something, or at least we need some style guidelines around size/color scheme/etc.

Once we understand what needs to happen visually we can get assets together and update the PR.

Also note that it would be nice to be able to provide both URL to present Balancer, and one to present the list of pools/positions that folks should be interacting with. Right now I used the filter list, because I think users will have a hard time understanding what to do without it, and we don't want lots of chaos and confusion.

Please also note that none of the image URLs are images right now. Our design team needs to see where the images will go to make something, or at least we need some style guidelines around size/color scheme/etc.

Once we understand what needs to happen visually we can get assets together and update the PR.

Also note that it would be nice to be able to provide both URL to present Balancer, and one to present the list of pools/positions that folks should be interacting with. Right now I used the filter list, because I think users will have a hard time understanding what to do without it, and we don't want lots of chaos and confusion.

Hi @Tritium-VLK
About the image, a 384x384px image works, as regards the link the one that present the list of pools/positions that users should be interacting with is the better option as there's only room for one link. The only details of the image that matters is the dimension, you can go with whichever style guide you want to work with. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants