Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-navigation): stay on current location when changing lang #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JPSchellenberg
Copy link
Member

Hey,

I made the language selection so that it stays on the current location. This worked on the /support page, but now it should work for every page.

@JPSchellenberg JPSchellenberg self-assigned this Sep 8, 2021
@JPSchellenberg JPSchellenberg requested a review from sr258 September 8, 2021 14:00
@JPSchellenberg JPSchellenberg added the bug Something isn't working label Sep 8, 2021
@JPSchellenberg JPSchellenberg temporarily deployed to homepage-fix-language-s-btawkp September 8, 2021 14:00 Inactive
@sr258
Copy link
Member

sr258 commented Sep 17, 2021

@JPSchellenberg Is this resolved by the other PR as well? It looks like language switching from /fr/app/privacy-policy to "Home" still looses the language setting there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants