Upgrade build dependencies for the project #570
+18
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liutikas
commented
Nov 16, 2024
liutikas
commented
- Upgrade to Gradle 8.11
- Upgrade to Android Gradle Plugin 8.7.2
- Remove deprecated android.defaults.buildfeatures.buildconfig=true gradle property, it is not needed as mastodon/build.gradle already sets android { buildFeatures { buildConfig true } }
- Move plugin repository definition to settings.gradle to match latest Gradle practices
- Move to using plugin {} mechanism to add Android Gradle Plugin to match the latest Gradle practices
- Remove root project clean task as this project does not produce any real artifacts, it seems to be leftover from original Android new project template
- Upgrade to Gradle 8.11
- Upgrade to Android Gradle Plugin 8.7.2
- Remove deprecated android.defaults.buildfeatures.buildconfig=true
gradle property, it is not needed as mastodon/build.gradle already
sets android { buildFeatures { buildConfig true } }
- Move plugin repository definition to settings.gradle to match latest
Gradle practices
- Move to using plugin {} mechanism to add Android Gradle Plugin to
match the latest Gradle practices
- Remove root project clean task as this project does not produce any
real artifacts, it seems to be leftover from original Android new
project template
Goooler
approved these changes
Nov 17, 2024
Co-authored-by: Zongle Wang <[email protected]>
Co-authored-by: Zongle Wang <[email protected]>
|
Anything else missing to land this? |
|
We are currently rewriting the app from scratch based on upstream. We started it because of the tons of legacy code that were making maintenance a pain. So idk if this PR is relevant, as this issue has already been dealt with in the rewrite branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.