feat(Error): disable clicking + crash fix #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disable clicking on the ErrorStatusDisplayItem, since there is no valid content that can be displayed.
Fixes a crash, where the text of an hashtag was empty, leading to an oob string access.
LucasGGamerM
reviewed
Sep 2, 2024
As said above, there is no valid content that can be displayed. Opening the faulty Status may lead to further error, additional it's quite unexpected to be able to click on an error. |
Ohhh, that makes a lot of sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables clicking the ErrorStatusDisplayItem, since there is no valid content to be displayed.
Also fixes an issue, where non-mastodon posts could have hashtags without any text, which could lead to an oob String access, e.g.:
https://mastodon.social/@[email protected]/113050670800313268