fix(ComposeFragment): allow pixelfed replies with no attachements #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanubeki
reviewed
Aug 28, 2024
mastodon/src/main/java/org/joinmastodon/android/fragments/ComposeFragment.java
Outdated
Show resolved
Hide resolved
FineFindus
force-pushed
the
fix/pixelfed-reply
branch
from
0be6b1a to
401f2b3
Compare
Pixelfed only allows posting posts with a text and atleast one attachements, but repliesn can be text only. Closing LucasGGamerM#519
FineFindus
force-pushed
the
fix/pixelfed-reply
branch
from
401f2b3 to
89af75a
Compare
|
Is this ready for review? |
|
Yes, otherwise I would have marked it as a draft :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pixelfed only allows posting with a text and at least one attachment, but replies can be text only.
Since I do not have a Pixelfed account, I was unable to verify that the code actually works.
Closing #519