-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iceshrimp improvements #516
base: master
Are you sure you want to change the base?
Iceshrimp improvements #516
Conversation
This information is very useful and it's loaded very quickly anyways
- Hide emoji reactions - Correctly set editedAt
The constructor of AccountSessionManager may need this object which could lead to a situation where it was being used before it had been created. Making it static and moving it to MastodonAPIRequest, the only place it was being used anyways, seems to fix the issue.
This is specifically for tapping existing reactions on a post if the user has already reached the instance max
We can be sure it doesn't support anything other than MFM
It's disabled anyways for new users, and allowing all lowers the chance of crashes from a previously selected option being missing
…o moshidon-iceshrimp-improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
I think it would be a good idea to add comments explaining some of the server-specific changes, e.g. //hide y because x doesn't support property z
. Makes it easier to understand why the code is like this when reading it later :)
mastodon/src/main/java/org/joinmastodon/android/model/Instance.java
Outdated
Show resolved
Hide resolved
mastodon/src/main/java/org/joinmastodon/android/fragments/ComposeFragment.java
Outdated
Show resolved
Hide resolved
I'm just thinking of how it's gonna be to merge this after I deal with the upstream merging 🤔 |
I just tried pulling all of mastodon-android/master into my branch and none of my changes seemed to make the merging process noticeably more difficult (than it already is) Close to all of the changes in this PR only build upon code that was already existent in Moshidon. More than a third of the changes are in a single file that doesn't even exist in mastodon-android (EmojiReactionsStatusDisplayItem). Almost this entire PR is simply making it so features already implemented to be used by i.e. Glitch or Akkoma instances also work well for Iceshrimp users |
Iceshrimp.NET now also implements some APIs using the pleroma field, so only checking for that would create false positives for Iceshrimp.NET
would it be possible to use the mastodon post visibility picker over the pleroma one as well? local-only posting does not function due to moshidon detecting it as pleroma. |
This would seemingly already have been fixed by a554059 |
Port of sk22#1000. The rest of this text is mostly just copied from there.
Lots of improvements to make the experience better on Iceshrimp. These include: