-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix empty hashtag as search result for '@' query for Pleroma #277
Conversation
Don't mix the PR's. Make a separate one for the other fix |
I didn't know that my commit would automatically go into the PR. How to remove second commit? |
You should drop the second commit and then force push it to your repo |
Should I do "Reset Current Branch to previous commit"? Or another way? |
This reverts commit 328d66a.
No, you should right click on the commits you wanna remove, and click 'Drop commits' |
Drop commits is unavailable for me in Android Studio. So 'Revert commits' done. Is it ok? |
Mkay, so just reset the branch to the hashtag fix commit, and then force push |
I found why I couldn't drop commit. Because of protection on master branch. |
I did it successfully on my end. No need to worry now |
For unknown reasons Pleroma server responses with empty hashtag
SearchResult
. Therefore, the client crashes when try to set an empty title resource (because of empty title) to a TextView during ListItem bind.So we just filter empty hashtag before it comes to the ViewModel.
Screenshot