feat: add option to mute hashtag #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes LucasGGamerM#260, by opening the create filter page
|
I think the way tusky does it is really really great. They put an icon to mute the Hashtag after the follow button (I think putting it before the follow button is best) and they also allow for unmuting hashtags directly from the hashtag view |
|
Muting/Unmuting a hashtag now shows a confirmation dialog. When muting a hashtag, the filter is created in the background with the hashtag as the title. |
|
This is indeed what I had planning for this. I will review it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #260 by adding the option to mute (create a filter) the hashtag.
This is marked as a draft because there are still some open questions, namely how the UI should handle hashtags that are already muted:
In the last two cases, the app has to query and iterate through the filters, as there is no native API to check if a hashtag is muted.
moshidon_mute_hashtag.mp4